Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility add links name to icons #438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Accessibility add links name to icons #438

wants to merge 1 commit into from

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Oct 26, 2023

resolve #437

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2023
@Arhell
Accessibility add links name to icons
452702f 
Signed-off-by: Arhell <arhell333@gmail.com>
Arhell
Arhell commented Oct 28, 2023
View reviewed changes
Copy link
Member Author

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevin-wangzefeng
Corrected using the example of the main site https://docusaurus.io/

@Arhell
Copy link
Member Author

Arhell commented Feb 19, 2024

Please take a look, it's been a while since you merged with the main branch.

Shelley-BaoYue
Shelley-BaoYue reviewed Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with frontend, I would like to learn what effect if we add this aria-label?

@Arhell
Copy link
Member Author

Arhell commented Feb 20, 2024

aria-label

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-label

@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2024
@kubeedge-bot
Copy link
Collaborator

@Arhell: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shelley-BaoYue Shelley-BaoYue Shelley-BaoYue left review comments

@dingyin dingyin Awaiting requested review from dingyin

@fisherxu fisherxu Awaiting requested review from fisherxu

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessibility add links name to icons
3 participants
@Arhell @kubeedge-bot @Shelley-BaoYue