Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nikhil/recentnewslayout #396

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nikhilchauhangithub
Copy link
Contributor

@nikhilchauhangithub nikhilchauhangithub commented Aug 6, 2023

  • Please check if the PR fulfills these requirements
  • [x ] The commit message follows our guidelines
  • [ x] Tests for the changes have been added (for bug fixes / features)
  • [ x] Docs have been added / updated (for bug fixes / features)

fixed the not responsive layout of the "Recent news section"
issue #386

before
localhost_3000_(iPhone 12 Pro) (2)

after
localhost_3000_(iPhone 12 Pro) (3)

Signed-off-by: nikhilchauhangithub <thisisnikhilchauhan@gmail.com>
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2023
@nikhilchauhangithub
Copy link
Contributor Author

@kevin-wangzefeng @Shelley-BaoYue @fisherxu kindly review this pr, this looks professional, if any changes are required, then i am open for it, Thank you

@kevin-wangzefeng
Copy link
Member

There's a conflict in src/components/blogPost/index.scss, can you take a look and resovle it? Thanks.

@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2023
@kubeedge-bot kubeedge-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2023
@nikhilchauhangithub
Copy link
Contributor Author

@kevin-wangzefeng i resolved the conflict, now its up for review, i am open for changes if any, Thanks

@nikhilchauhangithub
Copy link
Contributor Author

@kevin-wangzefeng any changes required here

@nikhilchauhangithub
Copy link
Contributor Author

@kevin-wangzefeng @fisherxu @Shelley-BaoYue let me know if any change required, pr works perfectly fine, kindly review it

@fisherxu
Copy link
Member

@nikhilchauhangithub The ci deploy failed, ptal

@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2023
@kubeedge-bot
Copy link
Collaborator

@nikhilchauhangithub: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants