Controller: impl Eq and PartialEq for Action
#993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for this. This seems reasonable to me! Needs the usual |
This comment was marked as off-topic.
This comment was marked as off-topic.
let Action supports Eq and PartialEq allow user write unit test when they want to check the action which returned by their codes Signed-off-by: Sherlock Holo <sherlockya@gmail.com>
Sherlock-Holo
force-pushed
the
eq-action
branch
from
936fb98
to
98f60a6
Compare
|
|
clux
changed the title
Action
clux
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let Action supports Eq and PartialEq allow user write unit test when
they want to check the action which returned by their codes
Motivation
the
Actiondoesn't implement theEqorPartialEq, when writing unit test, user can't check the returnedActionis correct or not.if
ActionimplementsEqandPartialEq, user can compare itSolution
add
#[derive(Eq, PartialEq)]forAction