Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[serde(default)] to metadata field of DynamicObject #987

Merged
merged 1 commit into from Aug 18, 2022

Conversation

pbzweihander
Copy link
Contributor

Motivation

This PR resolves #986.

Solution

Add #[serde(default)] to metadata filed of DynamicObject

Signed-off-by: pbzweihander <pbzweihander@gmail.com>
@pbzweihander pbzweihander force-pushed the dynamic-object-default-metadata branch from 238ddbe to 494fe49 Compare August 18, 2022 06:50
@clux clux added the changelog-add changelog added category for prs label Aug 18, 2022
@clux clux added this to the 0.75.0 milestone Aug 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #987 (494fe49) into master (3e4be7e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #987   +/-   ##
=======================================
  Coverage   72.37%   72.37%           
=======================================
  Files          64       64           
  Lines        4438     4438           
=======================================
  Hits         3212     3212           
  Misses       1226     1226           
Impacted Files Coverage Δ
kube-core/src/dynamic.rs 66.66% <ø> (ø)

@clux clux merged commit b4a5938 into kube-rs:master Aug 18, 2022
@pbzweihander pbzweihander deleted the dynamic-object-default-metadata branch August 18, 2022 08:47
@clux clux changed the title Add #[serde(default)] to metadata field of DynamicObject Add #[serde(default)] to metadata field of DynamicObject Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-add changelog added category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot deserialize PodExecOptions into DynamicObject
3 participants