fix duplicate finalizers race condition #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kube-rs#964 Signed-off-by: Alex Hunt <alex.hunt@materialize.com>
nightkr
approved these changes
Jul 28, 2022
Co-authored-by: Teo Klestrup Röijezon <teo@nullable.se> Signed-off-by: alex-hunt-materialize <86254996+alex-hunt-materialize@users.noreply.github.com>
nightkr
approved these changes
Jul 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #965 +/- ##
==========================================
- Coverage 72.48% 72.43% -0.05%
==========================================
Files 64 64
Lines 4426 4430 +4
==========================================
+ Hits 3208 3209 +1
- Misses 1218 1221 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for duplicate finalizers race condition, by testing that the finalizers haven't changed since we pulled the object.
I have confirmed that this doesn't break anything, but I have no idea how to test that it actually solves the issue.
Resolves #964
Motivation
If multiple controllers attempt to modify the finalizers for an object, they previously could make modifications that conflicted with each other. Finalizers are modified by list index, so we must know that the entire set of finalizers is the same to safely make any modifications.
Solution
Test that finalizers haven't changed since we pulled the object.