Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine errors for Native TLS #716

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Conversation

kazk
Copy link
Member

@kazk kazk commented Nov 17, 2021

Continuing #688

@kazk kazk added the errors error handling or error ergonomics label Nov 17, 2021
@kazk kazk mentioned this pull request Nov 17, 2021
19 tasks
@@ -63,11 +63,11 @@ pub enum Error {
#[error("SslError: {0}")]
SslError(String),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this after #704.

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and easy 👍

kube-client/src/client/tls.rs Outdated Show resolved Hide resolved
Signed-off-by: kazk <kazk.dev@gmail.com>
@kazk kazk merged commit 6bd7e05 into kube-rs:master Nov 18, 2021
@kazk kazk deleted the refine-errors-native-tls branch November 18, 2021 19:15
@clux clux added this to the 0.65.0 milestone Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors error handling or error ergonomics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants