Meta no longer clones - fixes #233 #311
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clux
commented
Aug 18, 2020
| @@ -50,7 +50,7 @@ async fn main() -> anyhow::Result<()> { | |||
| info!( | |||
| "Deleting {}: ({:?})", | |||
| Meta::name(&o), | |||
| o.status.unwrap().conditions.unwrap().last() | |||
| o.status.as_ref().unwrap().conditions.as_ref().unwrap().last() | |||
There was a problem hiding this comment.
This is the kind of awkwardness I am talking about ^
nightkr
reviewed
Aug 18, 2020
kube/src/api/metadata.rs
Outdated
Comment on lines
18
to
22
| fn name(&self) -> &String; | ||
| /// The namespace the resource is in | ||
| fn namespace(&self) -> Option<String>; | ||
| fn namespace(&self) -> &Option<String>; | ||
| /// Tthe resource version | ||
| fn resource_ver(&self) -> Option<String>; | ||
| fn resource_ver(&self) -> &Option<String>; |
There was a problem hiding this comment.
Should be &str and Option<&str>, respectively. That should cut down on the awkward as_ref()s, and Option<&T> is covered by the null pointer optimization.
There was a problem hiding this comment.
Pushed a change now that tries to do that signature. It shifts things a lot, but it doesn't feel any less awkward. If anything it feels more awkward internally.
clux
commented
Aug 18, 2020
nightkr
reviewed
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this is now causing more congestion on shared references (as seen in the examples), it makes it awkward when used with option heavy k8s_openapi.
If k8s_openapi implements Arnavion/k8s-openapi#72 then this will feel a lot less awkward and should almost certainly be merged then.
At any rate, wanted to see how this felt. Going to leave this one open for discussion for a bit.