Remove abandoned StreamSubscribe implementation
#1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was never properly usable without further integration, and as such was never stabilised. It is replaced via #1449 Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1470 +/- ##
=======================================
- Coverage 74.6% 74.4% -0.2%
=======================================
Files 79 78 -1
Lines 6871 6772 -99
=======================================
- Hits 5125 5034 -91
+ Misses 1746 1738 -8
|
mateiidavid
approved these changes
May 1, 2024
There was a problem hiding this comment.
Late on reviewing. fwiw I pondered a bit during these past few days on whether removing it outright is better than marking it as deprecated for a release or two. My main concern was that this is behind the same unstable flag as the newer API.
We can't really use this for anything though. It can't be threaded through a controller. Makes sense to me to just remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was never properly usable without further integration, and as such was never stabilised. It is replaced via #1449
..alternatively we could deprecate this for a few releases, doesn't hurt us either way, nothing relies on this.