Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy suggestions and warning removal #1436

Merged
merged 6 commits into from
Mar 22, 2024
Merged

clippy suggestions and warning removal #1436

merged 6 commits into from
Mar 22, 2024

Conversation

clux
Copy link
Member

@clux clux commented Mar 22, 2024

fixes:

  1. unused imports for docs (made explicit, or removed when unused afaikt)
  2. unused imports + attr style
  3. clone_from rather than assigning clone
  4. chrono's duration's now needs unwrap which is not const - Ergonomic replacements for panicking APIs. chronotope/chrono#1491

To see what the warnings looked like an hour ago. Look at the files annotated in the previous PR: https://github.com/kube-rs/kube/pull/1435/files#file-kube-client-src-client-mod-rs-L10

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added the changelog-exclude changelog excluded prs label Mar 22, 2024
@clux clux added this to the 0.89.0 milestone Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.2%. Comparing base (959986a) to head (f49d4ed).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1436   +/-   ##
=====================================
  Coverage   72.2%   72.2%           
=====================================
  Files         78      78           
  Lines       6546    6546           
=====================================
  Hits        4722    4722           
  Misses      1824    1824           
Files Coverage Δ
kube-client/src/api/entry.rs 80.3% <100.0%> (ø)
kube-client/src/client/auth/oidc.rs 57.3% <100.0%> (ø)
kube-client/src/client/mod.rs 72.2% <ø> (ø)
kube-client/src/lib.rs 75.2% <ø> (ø)
kube-runtime/src/events.rs 97.3% <ø> (ø)
kube-runtime/src/reflector/object_ref.rs 69.4% <ø> (ø)
kube/src/mock_tests.rs 97.9% <ø> (ø)
kube-client/src/client/auth/mod.rs 50.5% <83.4%> (ø)

they have done some questionable deprecations

Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux marked this pull request as ready for review March 22, 2024 18:24
@clux clux requested a review from nightkr March 22, 2024 18:24
it is for the same purpose so documenting it

Signed-off-by: clux <sszynrae@gmail.com>
kube-runtime/src/reflector/object_ref.rs Outdated Show resolved Hide resolved
kube/src/mock_tests.rs Show resolved Hide resolved
clux and others added 2 commits March 22, 2024 19:06
Co-authored-by: Natalie Klestrup Röijezon <nat.roijezon@stackable.tech>
Signed-off-by: Eirik A <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux merged commit bc74325 into main Mar 22, 2024
18 checks passed
@clux clux deleted the clippy-03-24 branch March 22, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants