Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s-openapi@0.17.0 and MK8SV #1116

Merged
merged 6 commits into from
Jan 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
fail-fast: false
matrix:
# Run these tests against older clusters as well
k8s: [v1.20, latest]
k8s: [v1.21, latest]
steps:
- uses: actions/checkout@v2
- uses: actions-rs/toolchain@v1
Expand Down Expand Up @@ -199,7 +199,7 @@ jobs:

- uses: nolar/setup-k3d-k3s@v1
with:
version: v1.20
version: v1.21
# k3d-kube
k3d-name: kube
# Used to avoid rate limits when fetching the releases from k3s repo.
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[![Crates.io](https://img.shields.io/crates/v/kube.svg)](https://crates.io/crates/kube)
[![Rust 1.60](https://img.shields.io/badge/MSRV-1.60-dea584.svg)](https://github.com/rust-lang/rust/releases/tag/1.60.0)
[![Tested against Kubernetes v1_20 and above](https://img.shields.io/badge/MK8SV-v1_20-326ce5.svg)](https://kube.rs/kubernetes-version)
[![Tested against Kubernetes v1_21 and above](https://img.shields.io/badge/MK8SV-v1_21-326ce5.svg)](https://kube.rs/kubernetes-version)
[![Best Practices](https://bestpractices.coreinfrastructure.org/projects/5413/badge)](https://bestpractices.coreinfrastructure.org/projects/5413)
[![Discord chat](https://img.shields.io/discord/500028886025895936.svg?logo=discord&style=plastic)](https://discord.gg/tokio)

Expand All @@ -17,7 +17,7 @@ Select a version of `kube` along with the generated [k8s-openapi](https://github
```toml
[dependencies]
kube = { version = "0.77.0", features = ["runtime", "derive"] }
k8s-openapi = { version = "0.16.0", features = ["v1_25"] }
k8s-openapi = { version = "0.16.0", features = ["v1_26"] }
```

[Features are available](https://github.com/kube-rs/kube/blob/main/kube/Cargo.toml#L18).
Expand Down Expand Up @@ -153,7 +153,7 @@ Kube has basic support ([with caveats](https://github.com/kube-rs/kube/issues?q=
```toml
[dependencies]
kube = { version = "0.77.0", default-features = false, features = ["client", "rustls-tls"] }
k8s-openapi = { version = "0.16.0", features = ["v1_25"] }
k8s-openapi = { version = "0.16.0", features = ["v1_26"] }
```

This will pull in `rustls` and `hyper-rustls`.
Expand Down
5 changes: 5 additions & 0 deletions deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -108,3 +108,8 @@ version = "0.36"
# ahash -> getrandom -> wasi old
# tokio -> mio -> wasi new
name = "wasi"

[[bans.skip]]
# waiting for pem to bump base64
# https://github.com/jcreekmore/pem-rs/blob/master/Cargo.toml#L16
name = "base64"
6 changes: 3 additions & 3 deletions e2e/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ name = "boot"
path = "boot.rs"

[features]
latest = ["k8s-openapi/v1_25"]
mk8sv = ["k8s-openapi/v1_20"]
latest = ["k8s-openapi/v1_26"]
mk8sv = ["k8s-openapi/v1_21"]
rustls = ["kube/rustls-tls"]
openssl = ["kube/openssl-tls"]

Expand All @@ -29,6 +29,6 @@ tracing = "0.1.36"
tracing-subscriber = "0.3.3"
futures = "0.3.17"
kube = { path = "../kube", version = "^0.77.0", default-features = false, features = ["client", "runtime", "ws", "admission", "gzip"] }
k8s-openapi = { version = "0.16.0", default-features = false }
k8s-openapi = { version = "0.17.0", default-features = false }
serde_json = "1.0.68"
tokio = { version = "1.14.0", features = ["full"] }
4 changes: 2 additions & 2 deletions examples/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ openssl-tls = ["kube/client", "kube/openssl-tls"]
rustls-tls = ["kube/client", "kube/rustls-tls"]
runtime = ["kube/runtime"]
ws = ["kube/ws"]
latest = ["k8s-openapi/v1_25"]
latest = ["k8s-openapi/v1_26"]

[dev-dependencies]
tokio-util = "0.7.0"
Expand All @@ -31,7 +31,7 @@ futures = "0.3.17"
jsonpath_lib = "0.3.0"
kube = { path = "../kube", version = "^0.77.0", default-features = false, features = ["admission"] }
kube-derive = { path = "../kube-derive", version = "^0.77.0", default-features = false } # only needed to opt out of schema
k8s-openapi = { version = "0.16.0", default-features = false }
k8s-openapi = { version = "0.17.0", default-features = false }
serde = { version = "1.0.130", features = ["derive"] }
serde_json = "1.0.68"
serde_yaml = "0.8.21"
Expand Down
3 changes: 2 additions & 1 deletion justfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ fmt:
rustfmt +nightly --edition 2021 $(find . -type f -iname *.rs)

doc:
RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --lib --workspace --features=derive,ws,oauth,jsonpatch,client,derive,runtime,admission,k8s-openapi/v1_25 --open
RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --lib --workspace --features=derive,ws,oauth,jsonpatch,client,derive,runtime,admission,k8s-openapi/v1_26 --open

# Unit tests
test:
Expand Down Expand Up @@ -117,6 +117,7 @@ bump-k8s:
# bump mk8sv badge
badge="[![Tested against Kubernetes ${mk8svnew} and above](https://img.shields.io/badge/MK8SV-${mk8svnew}-326ce5.svg)](https://kube.rs/kubernetes-version)"
sd "^.+badge/MK8SV.+$" "${badge}" README.md
echo "remember to bump kubernetes-version.md in kube-rs/website"

# mode: makefile
# End:
Expand Down
12 changes: 6 additions & 6 deletions kube-client/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ config = ["__non_core", "pem", "dirs"]
__non_core = ["tracing", "serde_yaml", "base64"]

[package.metadata.docs.rs]
features = ["client", "rustls-tls", "openssl-tls", "ws", "oauth", "jsonpatch", "admission", "k8s-openapi/v1_25"]
features = ["client", "rustls-tls", "openssl-tls", "ws", "oauth", "jsonpatch", "admission", "k8s-openapi/v1_26"]
# Define the configuration attribute `docsrs`. Used to enable `doc_cfg` feature.
rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
base64 = { version = "0.13.0", optional = true }
base64 = { version = "0.20.0", optional = true }
chrono = { version = "0.4.23", optional = true, default-features = false }
dirs = { package = "dirs-next", optional = true, version = "2.0.0" }
serde = { version = "1.0.130", features = ["derive"] }
Expand All @@ -47,7 +47,7 @@ http-body = { version = "0.4.2", optional = true }
either = { version = "1.6.1", optional = true }
thiserror = "1.0.29"
futures = { version = "0.3.17", optional = true }
pem = { version = "1.0.1", optional = true }
pem = { version = "1.1.0", optional = true }
openssl = { version = "0.10.36", optional = true }
rustls = { version = "0.20.3", features = ["dangerous_configuration"], optional = true }
rustls-pemfile = { version = "1.0.0", optional = true }
Expand All @@ -70,7 +70,7 @@ tracing = { version = "0.1.36", features = ["log"], optional = true }
hyper-openssl = { version = "0.9.2", optional = true }

[dependencies.k8s-openapi]
version = "0.16.0"
version = "0.17.0"
default-features = false
features = []

Expand All @@ -83,6 +83,6 @@ tokio-test = "0.4.0"
tower-test = "0.4.0"

[dev-dependencies.k8s-openapi]
version = "0.16.0"
version = "0.17.0"
default-features = false
features = ["v1_25"]
features = ["v1_26"]
4 changes: 1 addition & 3 deletions kube-client/src/api/util/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@ use k8s_openapi::api::{
use kube_core::{params::PostParams, util::Restart};
use serde::de::DeserializeOwned;

k8s_openapi::k8s_if_ge_1_19! {
mod csr;
}
mod csr;

impl<K> Api<K>
where
Expand Down
8 changes: 4 additions & 4 deletions kube-core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ repository = "https://github.com/kube-rs/kube"
readme = "../README.md"

[package.metadata.docs.rs]
features = ["ws", "admission", "jsonpatch", "k8s-openapi/v1_25"]
features = ["ws", "admission", "jsonpatch", "k8s-openapi/v1_26"]
rustdoc-args = ["--cfg", "docsrs"]

[features]
Expand All @@ -34,14 +34,14 @@ chrono = { version = "0.4.19", default-features = false, features = ["clock"] }
schemars = { version = "0.8.6", optional = true }

[dependencies.k8s-openapi]
version = "0.16.0"
version = "0.17.0"
default-features = false
features = []

[dev-dependencies.k8s-openapi]
version = "0.16.0"
version = "0.17.0"
default-features = false
features = ["v1_25"]
features = ["v1_26"]

[dev-dependencies]
assert-json-diff = "2.0.1"
Expand Down
2 changes: 1 addition & 1 deletion kube-derive/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ proc-macro = true
serde = { version = "1.0.130", features = ["derive"] }
serde_yaml = "0.8.21"
kube = { path = "../kube", default-features = false, version = "<1.0.0, >=0.61.0", features = ["derive"] }
k8s-openapi = { version = "0.16.0", default-features = false, features = ["v1_25"] }
k8s-openapi = { version = "0.17.0", default-features = false, features = ["v1_26"] }
schemars = { version = "0.8.6", features = ["chrono"] }
validator = { version = "0.16.0", features = ["derive"] }
chrono = { version = "0.4.19", default-features = false }
Expand Down
8 changes: 4 additions & 4 deletions kube-runtime/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ rust-version = "1.60.0"
edition = "2021"

[package.metadata.docs.rs]
features = ["k8s-openapi/v1_25"]
features = ["k8s-openapi/v1_26"]
# Define the configuration attribute `docsrs`. Used to enable `doc_cfg` feature.
rustdoc-args = ["--cfg", "docsrs"]

Expand All @@ -37,7 +37,7 @@ thiserror = "1.0.29"
backoff = "0.4.0"

[dependencies.k8s-openapi]
version = "0.16.0"
version = "0.17.0"
default-features = false

[dev-dependencies]
Expand All @@ -48,6 +48,6 @@ rand = "0.8.0"
schemars = "0.8.6"

[dev-dependencies.k8s-openapi]
version = "0.16.0"
version = "0.17.0"
default-features = false
features = ["v1_25"]
features = ["v1_26"]
5 changes: 2 additions & 3 deletions kube-runtime/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@
#![allow(clippy::semicolon_if_nothing_returned)]

pub mod controller;
k8s_openapi::k8s_if_ge_1_19! {
pub mod events;
}
pub mod events;

pub mod finalizer;
pub mod reflector;
pub mod scheduler;
Expand Down
8 changes: 4 additions & 4 deletions kube/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ config = ["kube-client/config"]
runtime = ["kube-runtime"]

[package.metadata.docs.rs]
features = ["client", "rustls-tls", "openssl-tls", "derive", "ws", "oauth", "jsonpatch", "admission", "runtime", "k8s-openapi/v1_25"]
features = ["client", "rustls-tls", "openssl-tls", "derive", "ws", "oauth", "jsonpatch", "admission", "runtime", "k8s-openapi/v1_26"]
# Define the configuration attribute `docsrs`. Used to enable `doc_cfg` feature.
rustdoc-args = ["--cfg", "docsrs"]

Expand All @@ -43,7 +43,7 @@ kube-runtime = { path = "../kube-runtime", version = "=0.77.0", optional = true}
# Not used directly, but required by resolver 2.0 to ensure that the k8s-openapi dependency
# is considered part of the "deps" graph rather than just the "dev-deps" graph
[dependencies.k8s-openapi]
version = "0.16.0"
version = "0.17.0"
default-features = false

[dev-dependencies]
Expand All @@ -55,6 +55,6 @@ serde = { version = "1.0.130", features = ["derive"] }
schemars = "0.8.6"

[dev-dependencies.k8s-openapi]
version = "0.16.0"
version = "0.17.0"
default-features = false
features = ["v1_25"]
features = ["v1_26"]
4 changes: 2 additions & 2 deletions release.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
# 0. (optional) cargo release minor ; verify readme + changelog bumped; then git reset --hard
# 1. PUBLISH_GRACE_SLEEP=20 cargo release minor --execute
# 1X. - on failure: follow plan manually, cd into next dirs and publish insequence with cargo publish --features=k8s-openapi/v1_25
# 1X. - on failure: follow plan manually, cd into next dirs and publish insequence with cargo publish --features=k8s-openapi/v1_26
# 2. check consolidated commit
# 2X. - on failure: git commit --amend and insert version
# 3. ./scripts/release-post.sh
Expand All @@ -21,4 +21,4 @@ push = false
tag = false
# A Kubernetes version is normally supplied by the application consuming the library in the end.
# Since we don't have that when verifying, supply one ourselves.
enable-features = ["k8s-openapi/v1_25"]
enable-features = ["k8s-openapi/v1_26"]