Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base64 requirement from 0.13.0 to 0.20.0 #1103

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 12, 2022

Updates the requirements on base64 to permit the latest version.

Changelog

Sourced from base64's changelog.

0.20.0

Breaking changes

  • Update MSRV to 1.57.0
  • Decoding can now either ignore padding, require correct padding, or require no padding. The default is to require correct padding.
    • The NO_PAD config now requires that padding be absent when decoding.

0.20.0-alpha.1

Breaking changes

  • Extended the Config concept into the Engine abstraction, allowing the user to pick different encoding / decoding implementations.
    • What was formerly the only algorithm is now the FastPortable engine, so named because it's portable (works on any CPU) and relatively fast.
    • This opens the door to a portable constant-time implementation (#153, presumably ConstantTimePortable?) for security-sensitive applications that need side-channel resistance, and CPU-specific SIMD implementations for more speed.
    • Standard base64 per the RFC is available via DEFAULT_ENGINE. To use different alphabets or other settings (padding, etc), create your own engine instance.
  • CharacterSet is now Alphabet (per the RFC), and allows creating custom alphabets. The corresponding tables that were previously code-generated are now built dynamically.
  • Since there are already multiple breaking changes, various functions are renamed to be more consistent and discoverable.
  • MSRV is now 1.47.0 to allow various things to use const fn.
  • DecoderReader now owns its inner reader, and can expose it via into_inner(). For symmetry, EncoderWriter can do the same with its writer.
  • encoded_len is now public so you can size encode buffers precisely.

0.13.1

  • More precise decode buffer sizing, avoiding unnecessary allocation in decode_config.

0.13.0

  • Config methods are const
  • Added EncoderStringWriter to allow encoding directly to a String
  • EncoderWriter now owns its delegate writer rather than keeping a reference to it (though refs still work)
    • As a consequence, it is now possible to extract the delegate writer from an EncoderWriter via finish(), which returns Result<W> instead of Result<()>. If you were calling finish() explicitly, you will now need to use let _ = foo.finish() instead of just foo.finish() to avoid a warning about the unused value.
  • When decoding input that has both an invalid length and an invalid symbol as the last byte, InvalidByte will be emitted instead of InvalidLength to make the problem more obvious.

0.12.2

  • Add BinHex alphabet

0.12.1

  • Add Bcrypt alphabet

0.12.0

  • A Read implementation (DecoderReader) to let users transparently decoded data from a b64 input source
  • IMAP's modified b64 alphabet
  • Relaxed type restrictions to just AsRef<[ut8]> for main encode*/decode* functions
  • A minor performance improvement in encoding

0.11.0

  • Minimum rust version 1.34.0

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies upgrades to dependencies label Dec 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Merging #1103 (b3a9f42) into main (c04539f) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
+ Coverage   72.48%   72.50%   +0.02%     
==========================================
  Files          65       65              
  Lines        4848     4848              
==========================================
+ Hits         3514     3515       +1     
+ Misses       1334     1333       -1     
Impacted Files Coverage Δ
kube-runtime/src/wait.rs 77.35% <0.00%> (+1.88%) ⬆️

@dependabot dependabot bot force-pushed the dependabot/cargo/base64-0.20.0 branch from 5f4d364 to 3382331 Compare December 12, 2022 05:38
@clux
Copy link
Member

clux commented Dec 12, 2022

hm, it is possible that the new stricter padding functionality via marshallpierce/rust-base64#198 can cause some problems if certain parts of Kubernetes that generates our Kubeconfigs are lax with base64 padding standards. It does look like a good change either way though. Probably merging this next week (or before a release) if nothing ominous pops up in the library.

@clux clux added this to the 0.77.0 milestone Dec 12, 2022
@clux clux added the changelog-change changelog change category for prs label Dec 12, 2022
@dependabot dependabot bot force-pushed the dependabot/cargo/base64-0.20.0 branch from 3382331 to 6754aaa Compare December 12, 2022 07:24
@clux
Copy link
Member

clux commented Dec 12, 2022

Ah, we are blocked on a new k8s-openapi release bumping this for cargo-deny. Keeping this open, but will re-check this after a k8s-openapi release.

@dependabot ignore this minor version

@dependabot dependabot bot closed this Dec 12, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 12, 2022

OK, I won't notify you about version 0.20.x again, unless you re-open this PR. 😢

@dependabot dependabot bot deleted the dependabot/cargo/base64-0.20.0 branch December 12, 2022 07:51
@clux clux removed this from the 0.77.0 milestone Dec 12, 2022
@clux clux restored the dependabot/cargo/base64-0.20.0 branch December 12, 2022 07:51
@clux clux reopened this Dec 12, 2022
@jesperpedersen
Copy link

jesperpedersen commented Dec 12, 2022

Arnavion/k8s-openapi#130 Merged

@clux clux added this to the 0.78.0 milestone Dec 14, 2022
@dependabot dependabot bot force-pushed the dependabot/cargo/base64-0.20.0 branch from 6754aaa to 0bc5428 Compare December 15, 2022 02:20
Updates the requirements on [base64](https://github.com/marshallpierce/rust-base64) to permit the latest version.
- [Release notes](https://github.com/marshallpierce/rust-base64/releases)
- [Changelog](https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md)
- [Commits](marshallpierce/rust-base64@v0.13.0...v0.20.0)

---
updated-dependencies:
- dependency-name: base64
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/base64-0.20.0 branch from 0bc5428 to b3a9f42 Compare December 15, 2022 02:30
@clux clux mentioned this pull request Jan 5, 2023
6 tasks
@clux
Copy link
Member

clux commented Jan 5, 2023

Replaced by #1116

@clux clux closed this Jan 5, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 5, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@clux clux deleted the dependabot/cargo/base64-0.20.0 branch January 5, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-change changelog change category for prs dependencies upgrades to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants