[windows] skip window creation on auth exec #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: goenning <me@goenning.net>
Signed-off-by: goenning <me@goenning.net>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1095 +/- ##
=======================================
Coverage 72.66% 72.66%
=======================================
Files 65 65
Lines 4832 4832
=======================================
Hits 3511 3511
Misses 1321 1321
|
kazk
reviewed
Dec 2, 2022
Co-authored-by: kazk <kazk.dev@gmail.com> Signed-off-by: Guilherme Oenning <me@goenning.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: goenning me@goenning.net
Motivation
When using kube-rs on a Windows GUI application, the auth exec is showing a terminal window during execution. It often takes less than 1 second, but it's noticeable enough to become annoying :)
2022-12-02-11-32-00.mp4
Solution
use the CREATE_NO_WINDOW flag to omit that.