Improve error message on azure auth not being supported #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: goenning <me@goenning.net>
clux
approved these changes
Nov 17, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1082 +/- ##
==========================================
- Coverage 72.48% 72.45% -0.04%
==========================================
Files 65 65
Lines 4757 4759 +2
==========================================
Hits 3448 3448
- Misses 1309 1311 +2
|
Closed
aviramha
pushed a commit
to metalbear-co/kube
that referenced
this pull request
Nov 19, 2022
be more explicit on azure auth not being supported Signed-off-by: goenning <me@goenning.net> Signed-off-by: goenning <me@goenning.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: goenning me@goenning.net
Motivation
It's reasonable not to support the deprecated azure auth provider, but the error message should guide users to an alternative, like kubectl does.
Solution
Improve error message. This should close #501 IMO