Bump tracing dependency to 0.1.36 #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightkr
added
bug
This was already required in practice, we just forgot to bump the version bound accordingly. Fixes #1069. Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se>
nightkr
force-pushed
the
bugfix/tracing-0.1.36
branch
from
98fe768
to
a2da77a
Compare
|
I'm not sure I'd say this warrants a patch release, since there's a pretty trivial workaround ("just run |
kazk
approved these changes
Nov 2, 2022
|
Having a patch release with this fix would be great |
|
Should it be |
The change that we depend on was introduced in 0.1.36. This is just the minimum bound, most users will still get 0.1.37 anyway unless they have a reason to lock it to something lower. |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already required in practice, we just forgot to bump the version bound accordingly.
Fixes #1069.