Add DynamicObjects::try_parse for typed object conversion
#1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clux
reviewed
Oct 27, 2022
clux
changed the title
DynamicObjects::try_parse for dyn -> typed object conversion
clux
changed the title
DynamicObjects::try_parse for dyn -> typed object conversionDynamicObjects::try_parse for typed object conversion
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
+ Coverage 72.32% 72.36% +0.04%
==========================================
Files 65 65
Lines 4704 4712 +8
==========================================
+ Hits 3402 3410 +8
Misses 1302 1302
|
Issue: kube-rs#1029 To avoid manually parsing DynamicObjects into resources, this commit implements DynamicOjbect::try_parse. The try_parse method will attempt to parse the DynamicObject into a type implementing the Resource trait, using serde. Signed-off-by: Jessie Chatham Spencer <jessie@teainspace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jessie Chatham Spencer jessie@teainspace.com
Motivation
Issue #1029 requests a method to convert a
DynamicObjectinto aResource. Such a method would avoid having to repeatedly implement this logic.Solution
This PR implements the
DynamicObject::try_parsemethod to facilitate easy conversion from aDynamicObjectto aResource. The method usesserde_jsonto first serialize theDynamicObjectand then deserialize the JSON to theResource.A small error type
ParseDynamicObjectErrorhas been implemented as well to represent a parsing failure. It wraps the originalserde_json::Errorso the original error information is preserved.