WIP: Core methods on Client
#1037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clux <sszynrae@gmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
==========================================
- Coverage 72.76% 72.16% -0.60%
==========================================
Files 66 67 +1
Lines 5063 5105 +42
==========================================
Hits 3684 3684
- Misses 1379 1421 +42
|
Signed-off-by: clux <sszynrae@gmail.com>
|
Going to pause this to tackle #1036 first. It's not possible to proceed with making subresource requests sane without at least having |
|
closed in favour of #1375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to implement core methods on
Clientdirectly as a WIP for #1032.Features:
createanddeletein all scopescreate_subresourcein NS + Cluster scopeEarly draft. Super ugly, undocumented, and a sketch. But wanted to show work early. Needs Api to move over to use these.