Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verify_tls1x_signature for NoCertVerification #1034

Merged
merged 1 commit into from Sep 29, 2022
Merged

Add verify_tls1x_signature for NoCertVerification #1034

merged 1 commit into from Sep 29, 2022

Conversation

rvql
Copy link
Contributor

@rvql rvql commented Sep 28, 2022 •
edited

Closes #1033

Signed-off-by: JIN Jie jinjie@yunshan.net.cn

Motivation

Kube client is not ignoring invalid certificates when using with rustls as described in #1033.

Solution

Implementing verify_tls13_signature and verify_tls12_signature for NoCertificateVerification to ignore the certificate.

@rvql
Add verify_tls1x_signature for NoCertVerification
ae9dc28 
Closes kube-rs#1033

Signed-off-by: Jin Jie <jinjie@yunshan.net.cn>
@clux clux added the changelog-fix changelog fix category for prs label Sep 28, 2022
@clux clux added this to the 0.76.0 milestone Sep 28, 2022
clux
clux approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks a lot!

@clux clux merged commit dd2364e into kube-rs:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Milestone
0.76.0
Development

Successfully merging this pull request may close these issues.

Kube client is not ignoring invalid certificates when using with rustls
2 participants
@rvql @clux