Skip to content

Commit

Permalink
fix review
Browse files Browse the repository at this point in the history
Signed-off-by: chengqinglin <chengqinglin@icloud.com>
  • Loading branch information
imuxin committed Sep 30, 2022
1 parent 4bdfe02 commit e334d67
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion kube-client/src/discovery/apigroup.rs
Expand Up @@ -243,7 +243,7 @@ impl ApiGroup {
self.versioned_resources(ver)
}

/// Returns all (including the lost in the lower group version) resources having the most stable version.
/// Returns all resources in the group at their the most stable respective version
///
/// ```no_run
/// use kube::{Client, api::{Api, DynamicObject}, discovery::{self, verbs}, ResourceExt};
Expand Down
6 changes: 3 additions & 3 deletions kube/src/lib.rs
Expand Up @@ -435,7 +435,7 @@ mod test {
}

#[tokio::test]
#[ignore] // needs cluster (fetches api resources, and lists all)
// #[ignore] // needs cluster (fetches api resources, and lists all)
#[cfg(all(feature = "derive"))]
async fn derived_resources_by_stability_discoverable() -> Result<(), Box<dyn std::error::Error>> {
use crate::{
Expand Down Expand Up @@ -500,8 +500,8 @@ mod test {

// run (almost) full discovery
let discovery = Discovery::new(client.clone())
// skip something in discovery (clux.dev crd being mutated in other tests)
.exclude(&["rbac.authorization.k8s.io", "clux.dev"])
// only include kube.rs in discovery
.filter(&["kube.rs"])
.run()
.await?;

Expand Down

0 comments on commit e334d67

Please sign in to comment.