Skip to content

Commit

Permalink
Update kube-client/src/client/auth/mod.rs
Browse files Browse the repository at this point in the history
Co-authored-by: Eirik A <sszynrae@gmail.com>
Signed-off-by: Aviram Hassan <aviramyhassan@gmail.com>
  • Loading branch information
aviramha and clux committed Nov 19, 2022
1 parent bbdbc11 commit 8a47137
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion kube-client/src/client/auth/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,8 @@ fn token_from_gcp_provider(provider: &AuthProviderConfig) -> Result<ProviderToke
// Command-based token source
if let Some(cmd) = provider.config.get("cmd-path") {
let params = provider.config.get("cmd-args").cloned().unwrap_or_default();
// This does currently not exist upstream and cannot be specified on disk.
// NB: This property does currently not exist upstream in client-go
// See https://github.com/kube-rs/kube/issues/1060
let drop_env = provider.config.get("cmd-drop-env").cloned().unwrap_or_default();
// TODO splitting args by space is not safe
let mut command = Command::new(cmd);
Expand Down

0 comments on commit 8a47137

Please sign in to comment.