Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions, fix cache, move to chainguard, simplify docker flow #47

Merged
merged 29 commits into from
Mar 13, 2023

Conversation

clux
Copy link
Member

@clux clux commented Mar 12, 2023

  • Upgrading actions like in Try upgrading all the actions and switch to chainguard version-rs#14
  • Tried similar cache attempt except, but it's still not caching volume layers so moved back to manual building
  • Split docker job into two (otel + base) and using metadata action instead of our the old prep action which is nicer
  • Changing dockerfile setup to builder into chainguard (and moving out labels, populated by metadata action)
  • Minor cleanups here and there

Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux changed the title Bump actions Bump actions, fix cache, move to chainguard, simplify docker flow Mar 12, 2023
clux added 27 commits March 12, 2023 09:13
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux marked this pull request as ready for review March 13, 2023 06:56
@clux
Copy link
Member Author

clux commented Mar 13, 2023

now everything builds in 1m again.
kind of sad that the gha docker cache still does not cache mounted cache data, otherwise we could use the normal builder pattern, but i'm ok with invoking the docker build manually (or letting the user run cargo build --target directly if possible) if it means actually having caching work.
anyway this was a bit of experimentation for kube-rs/website#14

@clux clux merged commit 3552f49 into main Mar 13, 2023
@clux clux deleted the bump-actions branch March 13, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant