KTOR-5283 Support Default Value for missing Env Variables in YAML #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marychatte
reviewed
Dec 6, 2022
ktor-server/ktor-server-config-yaml/jvmAndNix/src/io/ktor/server/config/yaml/YamlConfig.kt
Show resolved
Hide resolved
marychatte
reviewed
Dec 6, 2022
Stexxe
reviewed
Dec 6, 2022
| @@ -133,6 +133,18 @@ class YamlConfigTest { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Please add a test when there is a default value, and an environment variable is set.
rsinukov
force-pushed
the
rsinukov/yaml-default
branch
from
8c6dc15
to
ba1fe6b
Compare
rsinukov
force-pushed
the
rsinukov/yaml-default
branch
from
ba1fe6b
to
e20b653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtrack.jetbrains.com/issue/KTOR-5283