Issue #1903. Added code to parse the url if valid else return null #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 27, 2022 19:04
# Conflicts: # ktor-http/common/src/io/ktor/http/Url.kt # ktor-http/common/test/io/ktor/tests/http/UrlTest.kt
This reverts commit f05b591.
rsinukov
suggested changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
ktor-Http
Motivation
issue #1903. Currently the Url parse return valid url when a bogus url is passed.
Solution
Added a function to the Url Companion object, which parse the urlstring and return the valid url if present else returns null instead of appending
http://localhostto the invalid url