KTOR-3248 Build Ktor on Apple Silicon #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coroutines debug JUnit timeout rule does not work due to wrong architecture: Kotlin/kotlinx.coroutines#3001, and is fixed with coroutines 1.6.0. Until release, workaround is included. |
hfhbd
force-pushed
the
hfhbd/KTOR-3248
branch
from
447e4aa
to
e9caf29
Compare
hfhbd
force-pushed
the
hfhbd/KTOR-3248
branch
3 times, most recently
from
3f0c5a6
to
ca9ccf8
Compare
|
@e5l Just keep in mind, after coroutines 1.6.0 release you could remove these blocks: // https://github.com/Kotlin/kotlinx.coroutines/issues/3001
val jna_version = "5.9.0"
api("net.java.dev.jna:jna:$jna_version")
api("net.java.dev.jna:jna-platform:$jna_version") |
|
@hfhbd, could you check the build? |
|
@e5l I already did. Reading only the log is not very helpful: |
hfhbd
force-pushed
the
hfhbd/KTOR-3248
branch
from
ca9ccf8
to
0743f98
Compare
|
lgtm, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Infrastructure
Motivation
It is not possible to build Ktor on Apple Silicon Mac.
https://youtrack.jetbrains.com/issue/KTOR-3248
Solution
Adopt Gradle targets