Reduce required JDK version for DefaultHeaders feature #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In regarding to this coroutines issue, probably it is better to avoid JDK with version lower than 1.8. |
e5l
reviewed
Oct 31, 2019
|
|
||
| private val UTC = ZoneId.of("UTC")!! // it is very important to get it like that | ||
| private val zoneUTCRules = UTC.rules | ||
| private val clock = config.clock | ||
|
|
||
| private var cachedDateTimeStamp: Long = 0L |
e5l
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Server, DefaultHeaders
Motivation
Currently, DefaultHeaders feature requires JDK8 due to java.time dependency. However, the only we need is GMT time formatting.
#1369 java.lang.NoClassDefFoundError: Failed resolution of: Ljava/time/ZoneId;
Solution
Migrate to ktor's
GMTDatewithCalendarinstantiation optimization.