fixup! fixup! KTOR-2036 Fix CIO connection limit

ktorio · Sep 1, 2022 · 0252f21 · 0252f21
1 parent 41b863d
commit 0252f21
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/ktor-client/ktor-client-cio/jvmAndNix/src/io/ktor/client/engine/cio/ConnectionFactory.kt b/ktor-client/ktor-client-cio/jvmAndNix/src/io/ktor/client/engine/cio/ConnectionFactory.kt
@@ -22,12 +22,14 @@ internal class ConnectionFactory(
         configuration: SocketOptions.TCPClientSocketOptions.() -> Unit = {}
     ): Socket {
         limit.acquire()
-        addressLimit.computeIfAbsent(address) { Semaphore(addressConnectionsLimit) }.acquire()
+        val addressSemaphore = addressLimit.computeIfAbsent(address) { Semaphore(addressConnectionsLimit) }
+        addressSemaphore.acquire()
 
         return try {
             aSocket(selector).tcpNoDelay().tcp().connect(address, configuration)
         } catch (cause: Throwable) {
             // a failure or cancellation
+            addressSemaphore.release()
             limit.release()
             throw cause
         }