Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ktor-swagger-ui plugin #81

Merged
merged 2 commits into from
May 17, 2024
Merged

add ktor-swagger-ui plugin #81

merged 2 commits into from
May 17, 2024

Conversation

mcxinyu
Copy link
Contributor

@mcxinyu mcxinyu commented May 9, 2024

confirm.

e5l
e5l approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mcxinyu, thanks for the PR, LGTM

@e5l
Copy link
Member

e5l commented May 14, 2024 •
edited

It looks like the generated project compilation fails with unresolved reference:

10:14:04     /mnt/agent/work/69bf223698a8ad7f/plugins/server/io.github.smiley4/ktor-swagger-ui/2.0/install.kt:2:12: Unresolved reference: group
10:14:04     /mnt/agent/work/69bf223698a8ad7f/plugins/server/io.github.smiley4/ktor-swagger-ui/2.0/install.kt:6:13: Unresolved reference: SwaggerUI
10:14:04     /mnt/agent/work/69bf223698a8ad7f/plugins/server/io.github.smiley4/ktor-swagger-ui/2.0/install.kt:8:13: Variable expected
10:14:04     /mnt/agent/work/69bf223698a8ad7f/plugins/server/io.github.smiley4/ktor-swagger-ui/2.0/install.kt:9:13: Variable expected
10:14:04     /mnt/agent/work/69bf223698a8ad7f/plugins/server/io.github.smiley4/ktor-swagger-ui/2.0/install.kt:12:13: Variable expected
10:14:04     /mnt/agent/work/69bf223698a8ad7f/plugins/server/io.github.smiley4/ktor-swagger-ui/2.0/install.kt:13:13: Variable expected
10:14:04     /mnt/agent/work/69bf223698a8ad7f/plugins/server/io.github.smiley4/ktor-swagger-ui/2.0/install.kt:14:13: Variable expected

@mcxinyu, Could you please check?

@mcxinyu
Copy link
Contributor Author

mcxinyu commented May 15, 2024 •
edited

It looks like the generated project compilation fails with unresolved reference:

10:14:04     /mnt/agent/work/69bf223698a8ad7f/plugins/server/io.github.smiley4/ktor-swagger-ui/2.0/install.kt:2:12: Unresolved reference: group
10:14:04     /mnt/agent/work/69bf223698a8ad7f/plugins/server/io.github.smiley4/ktor-swagger-ui/2.0/install.kt:6:13: Unresolved reference: SwaggerUI
10:14:04     /mnt/agent/work/69bf223698a8ad7f/plugins/server/io.github.smiley4/ktor-swagger-ui/2.0/install.kt:8:13: Variable expected
10:14:04     /mnt/agent/work/69bf223698a8ad7f/plugins/server/io.github.smiley4/ktor-swagger-ui/2.0/install.kt:9:13: Variable expected
10:14:04     /mnt/agent/work/69bf223698a8ad7f/plugins/server/io.github.smiley4/ktor-swagger-ui/2.0/install.kt:12:13: Variable expected
10:14:04     /mnt/agent/work/69bf223698a8ad7f/plugins/server/io.github.smiley4/ktor-swagger-ui/2.0/install.kt:13:13: Variable expected
10:14:04     /mnt/agent/work/69bf223698a8ad7f/plugins/server/io.github.smiley4/ktor-swagger-ui/2.0/install.kt:14:13: Variable expected

@mcxinyu, Could you please check?

copy that, and fixed it.

@e5l
Copy link
Member

e5l commented May 17, 2024

Thank you, merged!

@e5l e5l merged commit 3be0d02 into ktorio:main May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5l e5l e5l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcxinyu @e5l