feat(Buttons): Add destructive styles #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-gendron
force-pushed
the
dev/QLT-59
branch
from
9bfa70f
to
d784a81
Compare
Chris-V
reviewed
Jan 21, 2021
Comment on lines
+5
to
+7
| import { AbstractButton, getButtonTypeStyles } from './abstract-button'; | ||
|
|
||
| type ButtonType = 'primary' | 'secondary' | 'tertiary'; | ||
| type ButtonType = 'primary' | 'secondary' | 'tertiary' | 'destructive'; |
There was a problem hiding this comment.
ButtonType est dupliqué dans AbstractButton
There was a problem hiding this comment.
Je fais ça car react-docgen transfert pas les typings via les imports. Ça donne ça dans le Storybook:
Au lieu de:
C'est un problème qui perdure depuis un moment dans cette lib
reactjs/react-docgen#352 (comment)
| `; | ||
| } | ||
| }} | ||
| ${getButtonTypeStyles} |
There was a problem hiding this comment.
Ici aussi, ButtonProps duplique buttonType, inversed et theme de AbstractButton au lieu de composer son interface avec.
| import { AbstractButton, AbstractButtonProps } from './abstract-button'; | ||
| import { AbstractButton, getButtonTypeStyles } from './abstract-button'; | ||
|
|
||
| type ButtonType = 'primary' | 'secondary' | 'tertiary' | 'destructive'; |
There was a problem hiding this comment.
Même commentaires pour icon-button
meriouma
reviewed
Jan 21, 2021
meriouma
reviewed
Jan 21, 2021
|
Ah, et oublie pas de rebaser, sinon ça va 💥 |
meriouma
approved these changes
Jan 22, 2021
maxime-gendron
force-pushed
the
dev/QLT-59
branch
from
b9b7223
to
cbaf2d0
Compare
maxime-gendron
force-pushed
the
dev/QLT-59
branch
from
cbaf2d0
to
26b3f5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Ce PR ajoute le bouton destructif pour les components
IconButtonetButton. J'ai profité de l'occasion pour refactor les styles des boutons qui étaient les même dans les deux components. J'ai ajouté la fonctiongetButtonTypeStyles()dans le fileabstract-button.tsxpour garder ça DRY.Carte Jira
Questionnement
Les styles sont déjà testés dans les snapshots de
Button, donc je me demande si je retire les snapshot tests de styles pour `IconButton?Tests concernés
icon-button.test.tsx:Has disabled stylesHas primary stylesHas secondary stylesHas tertiary styles