New rule: No non numeric dimensions #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nex3 fyi |
nex3
reviewed
Aug 13, 2019
|
It's probably also a good idea to test that this only applies to unquoted strings. |
|
good call on the test! added a test case for that. |
nex3
reviewed
Aug 14, 2019
|
@kristerkari - ptal when you can! |
Sorry, I have been really busy for the last 2 weeks. I think that the new rules are okay, but only thing that remains is to think about the naming, are the rules names matching the stylelint naming conventions? Are the rules in the right "category"? etc. I will try to think about the names this weekend, and give suggestions for the names if I can come up with any. |
|
No worries! I appreciate all of your help and completely understand that you're busy. Thanks a lot! |
kristerkari
requested changes
Aug 26, 2019
kristerkari
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old sass/linter had a rule to ensure that string interpolated values didn't have units attached to them (because they'd be strings instead of numbers).
This rule replicates that. The tests are the same for the sass/linter rule + this rule, so I have good confidence it'll give the same user experience.