fix/service image name #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomalok
reviewed
Jun 1, 2021
tomalok
reviewed
Jun 1, 2021
tomalok
reviewed
Jun 2, 2021
mavogel
force-pushed
the
fix/service-image-name
branch
from
812ae72
to
ef61bd2
Compare
|
@tomalok thanks for all you input :) Let me know if there is anything else from your side. Feel free to close the conversations if they are resolved for you |
I appear to be unable to close conversations? (or maybe I'm just not finding the button to do so...) |
tomalok
reviewed
Jun 3, 2021
testdata/resources/docker_service/updateFailsAndRollbackConvergeConfig.tf
Outdated
Show resolved
Hide resolved
testdata/resources/docker_service/testAccDockerServicePrivateImageConverge.tf
Outdated
Show resolved
Hide resolved
testdata/resources/docker_service/testAccDockerServicePartialReplicationConfigStep3.tf
Outdated
Show resolved
Hide resolved
tomalok
reviewed
Jun 17, 2021
testdata/resources/docker_service/testAccDockerServiceConvergeAndStopGracefully.tf
Outdated
Show resolved
Hide resolved
testdata/resources/docker_service/testAccDockerServiceFullSpec.tf
Outdated
Show resolved
Hide resolved
testdata/resources/docker_service/testAccDockerServicePrivateImageConverge.tf
Outdated
Show resolved
Hide resolved
testdata/resources/docker_service/updateFailsAndRollbackConvergeConfig.tf
Outdated
Show resolved
Hide resolved
testdata/resources/docker_service/updateFailsAndRollbackConvergeConfig.tf
Show resolved
Hide resolved
because it only caused confusion. We use the sha256@hash now and docker_image resource.
and docker_image resource for testing examples to be consistent
to not pollute the local daemon
mavogel
force-pushed
the
fix/service-image-name
branch
from
132b9f4
to
fb9273d
Compare
because it's unstable and fails with 405s
suzuki-shunsuke
approved these changes
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker_imageresource to determine thesha256@<hash>digest for a imagedocker_imagedatasource