This repository has been archived by the owner on Jan 25, 2020. It is now read-only.
Allow The Passthru of Missing Properties File #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combined with this change to localizr we'll get a much better error message in the case that the props are missing: krakenjs/localizr#20
Closed
xjamundx
changed the title
| @@ -40,7 +40,7 @@ exports.create = function (config) { | |||
| global = context.global; | |||
| locals = context.get('context'); | |||
| locality = util.localityFromLocals(locals); | |||
| props = res.resolve(name, locality).file || i18n.contentPath; | |||
There was a problem hiding this comment.
In the case that the content supplied is missing we will just pass along undefined to signal that we couldn't find any properties file. This only matters if we call {@pre} somewhere in the file. Dust files don't need have content, so we preserve this and then if localizr is called to get the content we can say there with confidence: "Someone is asking for content and we can't find it"
|
Tests will fail here, but pass after we get the localizr changes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined with this change to localizr we'll get a much better error message in the case that the props are missing:
krakenjs/localizr#20