Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup workflow and update dependencies #12

Merged
merged 14 commits into from Aug 8, 2021
Merged

Setup workflow and update dependencies #12

merged 14 commits into from Aug 8, 2021

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Aug 5, 2021

This is the same that what was add for pretty
The go.sum was missing, I generated it.
I added badged and fix a golint warning

mmorel-35 and others added 12 commits August 5, 2021 08:16
Bumps [github.com/creack/pty](https://github.com/creack/pty) from 1.1.9 to 1.1.14.
- [Release notes](https://github.com/creack/pty/releases)
- [Commits](creack/pty@v1.1.9...v1.1.14)

---
updated-dependencies:
- dependency-name: github.com/creack/pty
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link
Owner

@kr kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks pretty good to me. I would just request we do the readme change in a separate PR so it doesn't hold up the dependency stuff.

Readme.md Outdated
@@ -0,0 +1,7 @@
This is a Go package for manipulating paragraphs of text.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to do one complete thing at a time in each PR. Renaming & updating the readme seems like a separate thing from updating dependencies to me. What do you think?

@kr kr merged commit a988ae8 into kr:main Aug 8, 2021
@kr
Copy link
Owner

kr commented Aug 8, 2021

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants