comparator for custom equality checks #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpdecker
reviewed
Aug 27, 2017
| if (this.options.comparator) { | ||
| if (Array.isArray(right)) { | ||
| right = right[0]; | ||
| } |
There was a problem hiding this comment.
What is this array lookup doing? Is there a case where arrays are passed in here?
There was a problem hiding this comment.
Yes there is some edge case - maybe because of how this lib uses tokenize() and join()
arrayDiff.tokenize = arrayDiff.join = function(value) {
return value.slice();
};
|
Any chance this gets merged? |
|
Merged, but rebased and fixed the handling of the array concern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended equal-function to support a custom comparator. Useful for
diffArray.Solves #183