-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add undefinedReplacement
option to diffJson
#156
Conversation
options = {}; | ||
} | ||
|
||
jsonDiff.undefinedReplacement = options.undefinedReplacement; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to assign undefinedReplacement
directly to jsonDiff
because this.options
is overriden each time at the base#diff
method (https://github.com/kpdecker/jsdiff/blob/master/src/diff/base.js#L10).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Humm. This is not ideal as it causes side effects in the global space. Did you try to pass options through?
]); | ||
}); | ||
|
||
it('should handle callback', function(done) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add this to keep coverage at 100% which was dropped due to the code below
if (typeof options === 'function') {
callback = options;
options = {};
}
options = {}; | ||
} | ||
|
||
jsonDiff.undefinedReplacement = options.undefinedReplacement; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Humm. This is not ideal as it causes side effects in the global space. Did you try to pass options through?
My apologies for distraction, it's indeed working with just options. If I recall correctly, I was trying to keep signature of I've pushed a new commit with changes |
@kpdecker Could you release a new version on npm, please? |
Released in 3.2.0 |
Fixes #155
Please, let me know if I need to change styling / rename
undefinedReplacement
to something more concise / anything else.