Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ArcWaker::into_waker() call #361

Merged
merged 1 commit into from Aug 13, 2019
Merged

Update ArcWaker::into_waker() call #361

merged 1 commit into from Aug 13, 2019

Conversation

jakmeier
Copy link
Contributor

Syntax of function has been changed
See rust-lang/futures-rs#1676

Syntax of cuntion has been changed
See rust-lang/futures-rs#1676
@jakmeier
Copy link
Contributor Author

Hi, I suggest this PR to fix the executors for futures to work with the latest nightly.
Currently, stdweb with futures-support does not compile.

To reproduce:
cargo web check --features=futures-support
Results in:

error[E0599]: no function or associated item named `into_waker` found for type `dyn futures_util::task::ArcWake` in the current scope
  --> src/webcore/executor.rs:74:34
   |
74 |             let waker = ArcWake::into_waker( arc.clone() );
   |                                  ^^^^^^^^^^ function or associated item not found in `dyn futures_util::task::ArcWake`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0599`.
error: Could not compile `stdweb`.

The commit from in nightly that changed the Syntax: rust-lang/futures-rs#1676

@koute
Copy link
Owner

koute commented Aug 13, 2019

Thanks!

@koute koute merged commit cc96683 into koute:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants