detail the expected user order #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I propose to detail the expected user order for users with same contributions in Aggregation.kt.
To Highlight my point, I adapted the test respectively the expected user list:
The existing aggregate implementation failed with the adapted expected user list in my tests.
However, the test passes with the adapted expected user list with the proposed detailed user order.
Please note: the key selector of fun groupBy recognizes Bob first and Beth afterwards, because Bob is part of the second element of the actual user list. The existing tests would pass in case Beth would be recognized by the key selector prior to Bob (e.g. as part of the first user list element).
Additional change: gradle patch version bump.