fix EventuallyPredicate, add a producerless version, and inform user …

[jschneidereit]

…about predicate failures for #2044

[xeruf]

yeah, might as well call it until again ^^

Either way, you need to rework or remove this, as it is incorrect:

suspend fun until(duration: Duration, interval: Interval = 1.seconds.fixed(), f: suspend () -> Boolean) =
   eventually(duration, interval, f = f)

It will return immediately after the first try if that doesn't throw an exception (which until lambdas are not supposed to do) regardless of the returned boolean value.

[sksamuel]

It will return immediately after the first try if that doesn't throw an exception (which until lambdas are not supposed to do) regardless of the returned boolean value.

That's how eventually has always worked - it looked for exceptions.

Now you can additionally evaluate the predicate, combining the power of both eventually and until.

[sksamuel]

Can we make this work without requiring the name overload ?

[xeruf]

That's how eventually has always worked - it looked for exceptions.

Yes, but until never worked like that, so this alias was bogus.

[sksamuel]

4.4.1 has been released with until restored and documented

…

On Tue, 9 Feb 2021, 04:00 Janek, ***@***.***> wrote: That's how eventually has always worked - it looked for exceptions. Yes, but until never worked like that, so this alias was bogus. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2046 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFVSGWDJ3MYIKTASTM5YFDS6EBTNANCNFSM4XD7XVHA> .