Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime proxy compatibility with CRI interface version #1593

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

hormes
Copy link
Member

@hormes hormes commented Aug 29, 2023

Ref #1051

This is an extension of the previous work on #1052 . The updated content here is:

  1. For unsupported rpc calls, they are transparently forwarded to the backend by default to deal with the increase or decrease of interfaces on minor versions
  2. Delete the processing of the image service part, and go to the process of 1
  3. Removed some code generated by mockgen, I should avoid using this way to write one-sided

@hormes hormes changed the title Fix runtime proxy compatibility with CRI interface version [WIP] Fix runtime proxy compatibility with CRI interface version Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (02f4c00) 65.27% compared to head (fdb8d76) 65.27%.
Report is 72 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1593   +/-   ##
=======================================
  Coverage   65.27%   65.27%           
=======================================
  Files         359      359           
  Lines       36712    36712           
=======================================
+ Hits        23962    23964    +2     
+ Misses      11000    10997    -3     
- Partials     1750     1751    +1     
Flag Coverage Δ
unittests 65.27% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...oordlet/util/runtime/handler/containerd_runtime.go 60.63% <ø> (ø)
pkg/runtimeproxy/resexecutor/cri/container.go 70.00% <ø> (ø)
pkg/runtimeproxy/resexecutor/cri/pod.go 72.54% <ø> (ø)
pkg/runtimeproxy/resexecutor/cri/utils.go 87.90% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hormes hormes changed the title [WIP] Fix runtime proxy compatibility with CRI interface version Fix runtime proxy compatibility with CRI interface version Aug 29, 2023
Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
@hormes hormes added this to the v1.4 milestone Sep 18, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 200406d into koordinator-sh:main Sep 26, 2023
19 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants