chore: Update providers list #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating providers, we need to keep in mind that existing accounts will keep the `providerId` that was selected when the user filled in the connection form. This means that while we want to keep displaying providers in alphabetical order, we also need to keep the existing match between provider and provider id. The `yarn providers` script is updated to make sure fetching the list of providers from https://coopcycle.org does not override existing providers but updates them instead and adds new providers starting with the next available provider id.
LucsT
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
When updating providers, we need to keep in mind that existing
accounts will keep the
providerIdthat was selected when the userfilled in the connection form.
This means that while we want to keep displaying providers in
alphabetical order, we also need to keep the existing match between
provider and provider id.
The
yarn providersscript is updated to make sure fetching the listof providers from https://coopcycle.org does not override existing
providers but updates them instead and adds new providers starting
with the next available provider id.