fix: Migrate invoices names with invalid amounts #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coopcycle can display orders amounts in French numeric format using a comma instead of a dot as decimals separator as is expected by Javascript numbers processing functions (e.g. `toFixed` and `parseFloat`). Since we were not replacing the commas with dots, this resulted in invoices being downloaded with the wrong amount and filename (since it contains the invoice amount). Now that we've fixed the amount parsing we need to migrate the invoices filenames using `shouldReplaceName`.
Problèmes à régler : - les attributs des entries passées à saveFiles ou saveBills ne sont pas sauvegardés dans CouchDB !!! - cela inclut vendorRef qui ne peut alors être utilisé lors de la déduplication a posteriori - il faut pour cela préciser l’option fileIdAttributes: ['vendorRef'] dès le début
taratatach
force-pushed
the
fix/old-invoices-names-with-invalid-amount
branch
from
2131c9b
to
e6a9b94
Compare
|
Seems a good strategy to me, if generating invalid filename is robust. Is there a problem with it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coopcycle can display orders amounts in French numeric format using
a comma instead of a dot as decimals separator as is expected by
Javascript numbers processing functions (e.g.
toFixedandparseFloat).Since we were not replacing the commas with dots, this resulted in
invoices being downloaded with the wrong amount and filename (since it
contains the invoice amount).
Now that we've fixed the amount parsing we need to migrate the
invoices filenames using
shouldReplaceName.