fix: Invoice date parsing #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The invoices list does not include the invoicing date but the delivery date but we use this date as invoicing date on our hand (for matching purposes and convenience). However, Coopcycle recently changed the delivery date to reflect the delivery time interval during which the delivery actually happened. We arbitrarily decided to use the beginning of the interval as invoicing time.
LucsT
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The invoices list does not include the invoicing date but the delivery
date but we use this date as invoicing date on our hand (for matching
purposes and convenience).
However, Coopcycle recently changed the delivery date to reflect the
delivery time interval during which the delivery actually happened.
We arbitrarily decided to use the beginning of the interval as
invoicing time.