fix: Filter out orders without generated invoices #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coopcycle does not generate invoices until explicitly requested by the user. They've recently changed their generation modal, asking if a given address should be used for billing but we don't yet offer our users this option in the connector configuration so we leave it to the user to generate the invoices on the provider's website. This means that some orders won't have a fileurl and should be filtered out of the `saveFiles` and `saveBills` calls.
LucsT
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coopcycle does not generate invoices until explicitly requested by
the user.
They've recently changed their generation modal, asking if a given
address should be used for billing but we don't yet offer our users
this option in the connector configuration so we leave it to the user
to generate the invoices on the provider's website.
This means that some orders won't have a fileurl and should be
filtered out of the
saveFilesandsaveBillscalls.