Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/16 b #37

Merged
merged 27 commits into from
Jun 20, 2022
Merged

Issues/16 b #37

merged 27 commits into from
Jun 20, 2022

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jun 20, 2022

No description provided.

Comment on lines 83 to 85
type gzipRW struct {
http.ResponseWriter
level int
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not wrap responseWriter since it breaks optional interfaces 
rs/cors#84 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Merging #37 (cb082bb) into issues/16 (79da00c) will increase coverage by 5.74%.
The diff coverage is 67.04%.

@@              Coverage Diff              @@
##           issues/16      #37      +/-   ##
=============================================
+ Coverage      71.81%   77.56%   +5.74%     
=============================================
  Files             10       10              
  Lines            589      575      -14     
=============================================
+ Hits             423      446      +23     
+ Misses           154      111      -43     
- Partials          12       18       +6     
Impacted Files Coverage Δ
middleware/gzip.go 69.00% <67.04%> (+28.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79da00c...cb082bb. Read the comment docs.

@komuw komuw merged commit 724cdb9 into issues/16 Jun 20, 2022
@komuw komuw deleted the issues/16-b branch June 20, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants