Skip to content

Commit

Permalink
Fix build errors on CircleCI
Browse files Browse the repository at this point in the history
This PR fixes the following build errors on CircleCI.
These tests were expected to be skipped by `broken_on: :jruby`.

```console
rspec ./spec/rubocop/cli_spec.rb:1632 # RuboCop::CLI configuration from
file fails when a configuration file has invalid YAML syntax
rspec ./spec/rubocop/cop/variable_force_spec.rb:36 #
RuboCop::Cop::VariableForce#process_node when processing a regex with
regopt does not raise an error
```

https://app.circleci.com/pipelines/github/rubocop/rubocop/6657/workflows/834f8c9c-af93-429c-b434-10b8fa481cdb/jobs/227978

The following is the result of checking by ssh to `jruby-9.3-ascii_spec` job of CircleCI.

```ruby
> ENV['CIRCLE_STAGE']
=> nil

> ENV['CIRCLE_JOB']
=> "jruby-9.3-ascii_spec"
```

`CIRCLE_STAGE` is not expected to return `nil`.

As far as I can tell, the description of the official documentation about
the `CIRCLE_JOB` built-in environment variables.

> The name of the current job.

https://circleci.com/docs/en/2.0/env-vars

This PR uses `CIRCLE_JOB` instead of `CIRCLE_STAGE` to resolve the error.
  • Loading branch information
koic committed Jun 29, 2022
1 parent 27b0882 commit f7935e5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@

config.after(:suite) { RuboCop::Cop::Registry.reset! }

if %w[ruby-head-ascii_spec ruby-head-spec].include? ENV.fetch('CIRCLE_STAGE', nil)
if %w[ruby-head-ascii_spec ruby-head-spec].include? ENV.fetch('CIRCLE_JOB', nil)
config.filter_run_excluding broken_on: :ruby_head
end

if %w[jruby-9.3-ascii_spec jruby-9.3-spec].include? ENV.fetch('CIRCLE_STAGE', nil)
if %w[jruby-9.3-ascii_spec jruby-9.3-spec].include? ENV.fetch('CIRCLE_JOB', nil)
config.filter_run_excluding broken_on: :jruby
end
end
Expand Down

0 comments on commit f7935e5

Please sign in to comment.