[Fix rubocop#10143] Fix an error for Lint/RequireRelativeSelfPath

Fixes rubocop#10143. This PR fixes an error for `Lint/RequireRelativeSelfPath` when using a variable as an argument of `require_relative`.
koic · Sep 29, 2021 · afa9bb5 · afa9bb5
1 parent 85d67c9
commit afa9bb5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/changelog/fix_an_error_for_lint_require_relative_self_path.md b/changelog/fix_an_error_for_lint_require_relative_self_path.md
@@ -0,0 +1 @@
+* [#10143](https://github.com/rubocop/rubocop/issues/10143): Fix an error for `Lint/RequireRelativeSelfPath` when using a variable as an argument of `require_relative`. ([@koic][])
diff --git a/lib/rubocop/cop/lint/require_relative_self_path.rb b/lib/rubocop/cop/lint/require_relative_self_path.rb
@@ -27,6 +27,7 @@ class RequireRelativeSelfPath < Base
 
         def on_send(node)
           return unless (required_feature = node.first_argument)
+          return unless required_feature.respond_to?(:value)
           return unless same_file?(processed_source.file_path, required_feature.value)
 
           add_offense(node) do |corrector|

diff --git a/spec/rubocop/cop/lint/require_relative_self_path_spec.rb b/spec/rubocop/cop/lint/require_relative_self_path_spec.rb
@@ -42,4 +42,10 @@
       require_relative 'foo.racc'
     RUBY
   end
+
+  it 'does not register an offense when using a variable as an argument of `require_relative`' do
+    expect_no_offenses(<<~RUBY, 'foo.rb')
+      Dir['test/**/test_*.rb'].each { |f| require_relative f }
+    RUBY
+  end
 end