[Fix rubocop#8821] Fix an incorrect autocorrect for `Style/NestedTern…

…aryOperator`

Fixes rubocop#8821

This PR fixes an incorrect autocorrect for `Style/NestedTernaryOperator` when
using a nested ternary operator expression with no parentheses on the outside.

CHANGELOG.md

@@ -14,6 +14,7 @@
 * [#8514](https://github.com/rubocop-hq/rubocop/issues/8514): Correct multiple `Style/MethodDefParentheses` per file. ([@rdunlop][])
 * [#8825](https://github.com/rubocop-hq/rubocop/issues/8825): Fix crash in `Style/ExplicitBlockArgument` when code is called outside of a method. ([@ghiculescu][])
 * [#8354](https://github.com/rubocop-hq/rubocop/issues/8354): Detect regexp named captures in `Style/CaseLikeIf` cop. ([@dsavochkin][])
+* [#8821](https://github.com/rubocop-hq/rubocop/issues/8821): Fix an incorrect autocorrect for `Style/NestedTernaryOperator` when using a nested ternary operator expression with no parentheses on the outside. ([@koic][])
 
 ### Changes
 

lib/rubocop/cop/style/nested_ternary_operator.rb

@@ -49,6 +49,8 @@ def if_node(node)
         end
 
         def remove_parentheses(source)
+          return source unless source.start_with?('(')
+
           source.gsub(/\A\(/, '').gsub(/\)\z/, '')
         end
       end

spec/rubocop/cop/style/nested_ternary_operator_spec.rb

@@ -34,6 +34,21 @@
     RUBY
   end
 
+  it 'registers an offense and corrects for a nested ternary operator expression with no parentheses on the outside' do
+    expect_offense(<<~RUBY)
+      x ? y + (z ? 1 : 0) : nil
+               ^^^^^^^^^ Ternary operators must not be nested. Prefer `if` or `else` constructs instead.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      if x
+        y + (z ? 1 : 0)
+      else
+        nil
+      end
+    RUBY
+  end
+
   it 'accepts a non-nested ternary operator within an if' do
     expect_no_offenses(<<~RUBY)
       a = if x