[Fix rubocop#9342] Fix an error for Lint/RedundantDirGlobSort

Fixes rubocop#9342. This PR fixes an error for `Lint/RedundantDirGlobSort` when using `collection.sort`.
koic · Jan 7, 2021 · 703325b · 703325b
1 parent 51d84ee
commit 703325b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/changelog/fix_an_error_for_lint_redundant_dir_glob_sort.md b/changelog/fix_an_error_for_lint_redundant_dir_glob_sort.md
@@ -0,0 +1 @@
+* [#9342](https://github.com/rubocop-hq/rubocop/issues/9342): Fix an error for `Lint/RedundantDirGlobSort` when using `collection.sort`. ([@koic][])
diff --git a/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb b/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb
@@ -34,11 +34,13 @@ class RedundantDirGlobSort < Base
 
         def on_send(node)
           return unless (receiver = node.receiver)
-          return unless receiver.receiver.const_type? && receiver.receiver.short_name == :Dir
+          return unless receiver.receiver&.const_type? && receiver.receiver.short_name == :Dir
           return unless GLOB_METHODS.include?(receiver.method_name)
 
-          add_offense(node.loc.selector) do |corrector|
-            corrector.remove(node.loc.selector)
+          selector = node.loc.selector
+
+          add_offense(selector) do |corrector|
+            corrector.remove(selector)
             corrector.remove(node.loc.dot)
           end
         end

diff --git a/spec/rubocop/cop/lint/redundant_dir_glob_sort_spec.rb b/spec/rubocop/cop/lint/redundant_dir_glob_sort_spec.rb
@@ -54,6 +54,12 @@
         end
       RUBY
     end
+
+    it 'does not register an offense when using `collection.sort`' do
+      expect_no_offenses(<<~RUBY)
+        collection.sort
+      RUBY
+    end
   end
 
   context 'when Ruby 2.7 or lower', :ruby27 do