[Fix rubocop#9907] Fix an incorrect auto-correct for Lint/UselessTimes

Fixes rubocop#9907. This PR fixes an incorrect auto-correct for `Lint/UselessTimes` when using block argument for `1.times`.
koic · Jul 3, 2021 · 64d06c6 · 64d06c6
1 parent d1e8f9b
commit 64d06c6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/changelog/fix_incorrect_autocorrect_for_lint_useless_time.md b/changelog/fix_incorrect_autocorrect_for_lint_useless_time.md
@@ -0,0 +1 @@
+* [#9907](https://github.com/rubocop/rubocop/issues/9907): Fix an incorrect auto-correct for `Lint/UselessTimes` when using block argument for `1.times`. ([@koic][])
diff --git a/lib/rubocop/cop/lint/useless_times.rb b/lib/rubocop/cop/lint/useless_times.rb
@@ -81,7 +81,7 @@ def autocorrect_block(corrector, node)
           return if block_reassigns_arg?(node, block_arg)
 
           source = node.body.source
-          source.gsub!(/\b#{block_arg}\b/, '1') if block_arg
+          source.gsub!(/\b#{block_arg}\b/, '0') if block_arg
 
           corrector.replace(node, fix_indentation(source, node.loc.column...node.body.loc.column))
         end

diff --git a/spec/rubocop/cop/lint/useless_times_spec.rb b/spec/rubocop/cop/lint/useless_times_spec.rb
@@ -55,7 +55,7 @@
     RUBY
 
     expect_correction(<<~RUBY)
-      something(1)
+      something(0)
     RUBY
   end
 
@@ -163,8 +163,8 @@ def foo
       RUBY
 
       expect_correction(<<~RUBY)
-        do_something(1)
-        do_something_else(1)
+        do_something(0)
+        do_something_else(0)
       RUBY
     end
 
@@ -205,7 +205,7 @@ def foo
       RUBY
 
       expect_correction(<<~RUBY)
-        do_something(1)
+        do_something(0)
         j = 1
         do_something_else(j)
       RUBY