[Fix rubocop#10763] Fix a false positive for `Layout/LineContinuation…

…Spacing` Fixes rubocop#10763. This PR fixes a false positive for `Layout/LineContinuationSpacing` when using continuation keyword `\` after `__END__`.
koic · Jun 28, 2022 · 562a9c1 · 562a9c1
1 parent f5b77c8
commit 562a9c1
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 0 deletions.
diff --git a/changelog/fix_a_false_positive_for_layout_line_continuation_spacing.md b/changelog/fix_a_false_positive_for_layout_line_continuation_spacing.md
@@ -0,0 +1 @@
+* [#10763](https://github.com/rubocop/rubocop/issues/10763): Fix a false positive for `Layout/LineContinuationSpacing` when using continuation keyword `\` after `__END__`. ([@koic][])
diff --git a/lib/rubocop/cop/layout/line_continuation_spacing.rb b/lib/rubocop/cop/layout/line_continuation_spacing.rb
@@ -32,10 +32,14 @@ class LineContinuationSpacing < Base
         extend AutoCorrector
 
         def on_new_investigation
+          last_line = last_line(processed_source)
+
           @ignored_ranges = string_literal_ranges(processed_source.ast) +
                             comment_ranges(processed_source.comments)
 
           processed_source.raw_source.lines.each_with_index do |line, index|
+            break if index >= last_line
+
             line_number = index + 1
             investigate(line, line_number)
           end
@@ -103,6 +107,12 @@ def comment_ranges(comments)
           comments.map(&:loc).map(&:expression)
         end
 
+        def last_line(processed_source)
+          last_token = processed_source.tokens.last
+
+          last_token ? last_token.line : processed_source.lines.length
+        end
+
         def ignore_range?(backtick_range)
           @ignored_ranges.any? { |range| range.contains?(backtick_range) }
         end

diff --git a/spec/rubocop/cop/layout/line_continuation_spacing_spec.rb b/spec/rubocop/cop/layout/line_continuation_spacing_spec.rb
@@ -79,6 +79,20 @@
         X
       RUBY
     end
+
+    it 'ignores when too much space in front of backslash after `__END__`' do
+      expect_no_offenses(<<~'RUBY')
+        foo
+        bar
+        __END__
+        baz    \
+        qux
+      RUBY
+    end
+
+    it 'ignores empty code' do
+      expect_no_offenses('')
+    end
   end
 
   context 'EnforcedStyle: no_space' do
@@ -159,5 +173,19 @@
         X
       RUBY
     end
+
+    it 'ignores when too much space in front of backslash after `__END__`' do
+      expect_no_offenses(<<~'RUBY')
+        foo
+        bar
+        __END__
+        baz    \
+        qux
+      RUBY
+    end
+
+    it 'ignores empty code' do
+      expect_no_offenses('')
+    end
   end
 end