Skip to content

Commit

Permalink
Drop Ruby 2.4 support
Browse files Browse the repository at this point in the history
RuboCop does not support Ruby 2.4.
rubocop/rubocop#9648

And toshimaru#111 requires this PR.
Therefore, this PR drops support for Ruby 2.4 to enable the same cops as rails/rails.
  • Loading branch information
koic committed Apr 23, 2021
1 parent e48f569 commit ddd9f2d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,14 @@ jobs:
test:
strategy:
matrix:
ruby: [2.4, 2.5, 2.6, 2.7, 3.0]
ruby: [2.5, 2.6, 2.7, 3.0]
gemfile:
- gemfiles/rubocop_1.8.gemfile
- gemfiles/rubocop_1.9.gemfile
- gemfiles/rubocop_1.10.gemfile
- gemfiles/rubocop_1.11.gemfile
- gemfiles/rubocop_1.12.gemfile
- gemfiles/rubocop_1.13.gemfile
exclude:
- ruby: 2.4
gemfile: gemfiles/rubocop_1.13.gemfile
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ $ rails generate rubocop_rails_config:install

### TargetRubyVersion

Although Rails 7 (edge) only supports Ruby 2.7 or more, rubocop-rails_config still supports Ruby 2.4 or more to support as many Ruby versions as possible.
Although Rails 7 (edge) only supports Ruby 2.7 or more, rubocop-rails_config still supports Ruby 2.5 or more to support as many Ruby versions as possible.

If you'd like to change `TargetRubyVersion`, see [Customization](#customization).

Expand Down
2 changes: 1 addition & 1 deletion rubocop-rails_config.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
spec.files = Dir["README.md", "LICENSE", "config/*.yml", "lib/**/*"]
spec.homepage = "https://github.com/toshimaru/rubocop-rails_config"
spec.license = "MIT"
spec.required_ruby_version = ">= 2.4.0"
spec.required_ruby_version = ">= 2.5.0"

spec.add_dependency "rubocop", ">= 1.8"
spec.add_dependency "rubocop-ast", ">= 1.0.1"
Expand Down

0 comments on commit ddd9f2d

Please sign in to comment.