Drop Ruby 2.4 support and require RuboCop 1.13 or higher

RuboCop does not support Ruby 2.4 and rails/rails uses RuboCop 1.13. - rubocop/rubocop#9648 - rails/rails@bbbc861 And toshimaru#111 requires this PR. Therefore, this PR drops support for Ruby 2.4 to enable the same cops as rails/rails.
koic · Apr 23, 2021 · 1d31d00 · 1d31d00
1 parent e48f569
commit 1d31d00
Show file tree

Hide file tree

Showing 9 changed files with 5 additions and 83 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -4,17 +4,9 @@ jobs:
   test:
     strategy:
       matrix:
-        ruby: [2.4, 2.5, 2.6, 2.7, 3.0]
+        ruby: [2.5, 2.6, 2.7, 3.0]
         gemfile:
-          - gemfiles/rubocop_1.8.gemfile
-          - gemfiles/rubocop_1.9.gemfile
-          - gemfiles/rubocop_1.10.gemfile
-          - gemfiles/rubocop_1.11.gemfile
-          - gemfiles/rubocop_1.12.gemfile
           - gemfiles/rubocop_1.13.gemfile
-        exclude:
-          - ruby: 2.4
-            gemfile: gemfiles/rubocop_1.13.gemfile
     env:
       BUNDLE_GEMFILE: ${{ matrix.gemfile }}
     runs-on: ubuntu-latest

diff --git a/Appraisals b/Appraisals
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-SUPPORTED_VERSIONS = %w[1.8 1.9 1.10 1.11 1.12 1.13].freeze
+SUPPORTED_VERSIONS = %w[1.13].freeze
 
 SUPPORTED_VERSIONS.each do |version|
   appraise "rubocop-#{version}" do

diff --git a/README.md b/README.md
@@ -35,7 +35,7 @@ $ rails generate rubocop_rails_config:install
 
 ### TargetRubyVersion
 
-Although Rails 7 (edge) only supports Ruby 2.7 or more, rubocop-rails_config still supports Ruby 2.4 or more to support as many Ruby versions as possible.
+Although Rails 7 (edge) only supports Ruby 2.7 or more, rubocop-rails_config still supports Ruby 2.5 or more to support as many Ruby versions as possible.
 
 If you'd like to change `TargetRubyVersion`, see [Customization](#customization).
 

diff --git a/gemfiles/rubocop_1.10.gemfile b/gemfiles/rubocop_1.10.gemfile
diff --git a/gemfiles/rubocop_1.11.gemfile b/gemfiles/rubocop_1.11.gemfile
diff --git a/gemfiles/rubocop_1.12.gemfile b/gemfiles/rubocop_1.12.gemfile
diff --git a/gemfiles/rubocop_1.8.gemfile b/gemfiles/rubocop_1.8.gemfile
diff --git a/gemfiles/rubocop_1.9.gemfile b/gemfiles/rubocop_1.9.gemfile
diff --git a/rubocop-rails_config.gemspec b/rubocop-rails_config.gemspec
@@ -10,9 +10,9 @@ Gem::Specification.new do |spec|
   spec.files                 = Dir["README.md", "LICENSE", "config/*.yml", "lib/**/*"]
   spec.homepage              = "https://github.com/toshimaru/rubocop-rails_config"
   spec.license               = "MIT"
-  spec.required_ruby_version = ">= 2.4.0"
+  spec.required_ruby_version = ">= 2.5.0"
 
-  spec.add_dependency "rubocop", ">= 1.8"
+  spec.add_dependency "rubocop", ">= 1.13"
   spec.add_dependency "rubocop-ast", ">= 1.0.1"
   spec.add_dependency "rubocop-performance", "~> 1.3"
   spec.add_dependency "rubocop-rails", "~> 2.0"